[PATCH] powerpc: add of_get_mac_address() and update fsl_soc.c to use it

Benjamin Herrenschmidt benh at kernel.crashing.org
Wed Feb 14 16:28:33 EST 2007


On Tue, 2007-02-13 at 23:17 -0600, Timur Tabi wrote:
> Benjamin Herrenschmidt wrote:
> >> +	return get_property(np, "address", NULL);
> > 
> > Since there is so much room for confusion with "address", please at
> > least do some basic sanity checking, like check that it's size is 6
> > bytes and maybe that the multicast bit isn't set.
> 
> Are you saying that some device trees have something *other* than a MAC 
> address in the 'address' property?

Yes, old Apple gear in some nodes, though I don't think in network
devices...

Ben.





More information about the Linuxppc-dev mailing list