virtio_net: set carrier on by default. Impact: fix carrier detection, older NetworkManager This is actually two fixes: 1) If the virtio_net device doesn't support carrier, the answer is "yes". This is because before the status feature there was no way of turning the link off in any host implementation, and it also helps (older) NetworkManager versions to see the device. 2) We should start with carrier on: virtnet_update_status() does nothing if the status hasn't changed (ie. doesn't call netif_carrier_on()). Reported-by: Pantelis Koukousoulas Signed-off-by: Rusty Russell --- drivers/net/virtio_net.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -795,7 +795,10 @@ static int virtnet_probe(struct virtio_d goto unregister; } + /* If we have no carrier info, the answer is "always on". */ vi->status = VIRTIO_NET_S_LINK_UP; + netif_carrier_on(vi->dev); + virtnet_update_status(vi); pr_debug("virtnet: registered device %s\n", dev->name);