<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Eugene Surovegin wrote:
<blockquote cite="mid20050506081805.GA19401@gate.ebshome.net"
type="cite">
<pre wrap="">On Fri, May 06, 2005 at 11:54:08AM +0400, Vitaly Bordug wrote:
[snip]
</pre>
<blockquote type="cite">
<pre wrap="">+static struct cpm2_fec_platform_data mpc82xx_fcc1_pdata = {
+ .cp_page = CPM_CR_FCC1_PAGE,
+ .cp_block = CPM_CR_FCC1_SBLOCK,
+ .clk_trx = (PC_F1RXCLK | PC_F1TXCLK),
+ .clk_route = CMX1_CLK_ROUTE,
+ .clk_mask = CMX1_CLK_MASK,
+ .mdio = PC_MDIO,
+ .mdck = PC_MDCK,
+
+ .device_flags = FSL_CPM2_FEC_BRD_HAS_PHY_INTR,
+ .phyid = 0,
+ .interruptPHY = SIU_INT_IRQ5,
+};
</pre>
</blockquote>
<pre wrap=""><!---->
Hmm, interruptPHY here still looks somewhat odd. Why not use the same
approach as for the rest of the fields - "default" if corresponding
define wasn't defined by the board port?
Not that I like this approach, IMHO there should be _NO_ defines at
all here and board setup code must fill them, but I guess it's OK
for now, mostly because there is no board specific files for 82xx
boards yet and this makes the patch quite small.
</pre>
</blockquote>
Eugene, <br>
Probably this is a better way?<br>
<br>
PHY_INTERRUPT is defined in the board-specific platforms/pq2ads.h
(likewise approach was used in 2.4). Others from this define crowd
should reside as they are IMHO, until we have some common
board-specific header for 82xx (or all these will be scattered along
different 82xx platform defines such as tqm8260.h etc. which is even
worse). What do you think?<br>
<br>
<pre class="moz-signature" cols="72">--
Sincerely,
Vitaly
</pre>
</body>
</html>