FCC Ethernet startup crash

Stefan Nickl Stefan.Nickl at kontron.com
Fri Apr 8 20:49:00 EST 2005


On Thu, 2005-04-07 at 09:36 -0700, Tom Rini wrote:
> > The patch Stefan Nickl gave to me works perfectly, and all it does is
> > basically move the fcc_restart.
> > The kernel was still calling fcc_restart twiche per FCC at startup (one
> > time on init_fcc_startup, and then again in fcc_open), now it just calls
> > it twice in fcc_open. Seems to work.
> 
> Would someone please post what's needed vs current'ish 2.6 so we can get
> the proper fix up & in? :)  With the Signed-off-by & all that.. Thanks.

I took a little longer because I was not happy with the simple
cut'n'paste version. I believe the actual problem is that fcc_restart()
mustn't be called before netif_start_queue(). So the original version
only shortens the race period, it does not actually resolve it.

Unfortunately I'm deprived of suitable hardware as the focus of my work
has shifted in the last months, so I urge everyone out there to give it
a try.

Signed-off-by: Stefan Nickl <Stefan.Nickl at kontron.com>

-- 
Stefan Nickl
Kontron Modular Computers

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fcc_enet_startup_crash_v2.patch
Type: text/x-patch
Size: 1828 bytes
Desc: not available
Url : http://ozlabs.org/pipermail/linuxppc-embedded/attachments/20050408/16a13815/attachment.bin 


More information about the Linuxppc-embedded mailing list