[PATCH] powerpc/8xx: tqm8xx: fix incorrect placement of __initdata tag

David Laight David.Laight at ACULAB.COM
Tue Oct 1 00:20:29 EST 2013


> __initdata tag should be placed between the variable name and equal
> sign for the variable to be placed in the intended .init.data section.
...
> -static struct __initdata cpm_pin tqm8xx_pins[] = {
> +static struct cpm_pin tqm8xx_pins[] __initdata = {

As far as gcc is concerned it can go almost anywhere before the '=',
even before the 'static'.
Splitting 'struct cpm_pin' does seem an odd choice.

The Linux coding standards might suggest a location.
I'd have thought that either before or after the 'static' would be best
(ie as a storage class qualifier).

	David





More information about the Linuxppc-dev mailing list