[PATCH 14/21] Introduce EEH device

Stephen Rothwell sfr at canb.auug.org.au
Fri Feb 24 23:46:10 EST 2012


Hi Gavin,

On Fri, 24 Feb 2012 17:38:11 +0800 Gavin Shan <shangw at linux.vnet.ibm.com> wrote:
>
> +#define EEH_DEV_TO_OF_NODE(edev)	(edev->dn)
> +#define EEH_DEV_TO_PCI_DEV(edev)	(edev->pdev)
> +#define OF_NODE_TO_EEH_DEV(dn)		((struct eeh_dev *)(dn->edev))
> +#define PCI_DEV_TO_EEH_DEV(pdev)	((struct eeh_dev *)(pdev->dev.archdata.edev))

You need to put parentheses around the use of macro arguments ... or,
even better, make these into "static inline" accessor functions (with
lower case names).

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20120224/a2eb02f2/attachment.pgp>


More information about the Linuxppc-dev mailing list