[PATCH] Adding ADMA support for PPC460EX DMA engine.

[Dan Williams]

On Thu, Jul 22, 2010 at 11:15 PM, Stefan Roese <sr at denx.de> wrote:
> Hi Marri,
>
> On Friday 23 July 2010 02:57:18 tmarri at amcc.com wrote:
>> From: Tirumala Marri <tmarri at amcc.com>
>>
>>   This patch will add ADMA support for DMA engine and HW offload for
>>   XOR/ADG (RAID-5/6) functionalities.
>>   1. It supports memcpy, xor, GF(2) based RAID-6.
>>   2. It supports interrupt based DMA completions.
>>   3. Also supports memcpy in RAID-1 case.
>>
>>   Kernel version: 2.6.35-rc5
>>
>>   Testing:
>>     Created RAID-5/6 arrays usign mdadm.
>>     And ran raw IO and filesystem IO to the RAID array.
>>     Chunk size 4k,64k was tested.
>>     RAID rebuild , disk fail, resync tested.
>>
>>   File names:
>>     This code is similar to ppc440spe . So I named the files as
>>     drivers/dma/ppc4xx/adma1.c and drivers/dma/ppc4xx/adma1.h
>
> As you describe above, a lot of the code seems to be copied from
> drivers/dma/ppc4xx/adma.c/h. Wouldn't it make more sense to factor out the
> common code instead of duplicating it?
>

Yes, and you might look to drivers/dma/iop-adma.c as an example of a
way to support similar hardware with a single code base.

--
Dan