[patch 2/2] kbuild: move -fno-dwarf2-cfi-asm to powerpc only

Michal Marek mmarek at suse.cz
Fri Feb 5 00:03:03 EST 2010


On 4.2.2010 00:22, Benjamin Herrenschmidt wrote:
> On Tue, 2010-02-02 at 14:40 -0800, akpm at linux-foundation.org wrote:
>> From: Andi Kleen <andi at firstfloor.org>
>>
>> Better dwarf2 unwind information is a good thing, it allows better
>> debugging with kgdb and crash and helps systemtap.
>>
>> Commit 003086497f07f7f1e67c0c295e261740f822b377 ("Build with
>> -fno-dwarf2-cfi-asm") disabled some CFI information globally to work
>> around a module loader bug on powerpc.
>>
>> But this disables the better unwind tables for all architectures, not just
>> powerpc.  Move the workaround to powerpc and also add a suitable comment
>> that's it really a workaround.
>>
>> This improves dwarf2 unwind tables on x86 at least.
>>
>> Signed-off-by: Andi Kleen <ak at linux.intel.com>
>> Cc: Kyle McMartin <kyle at mcmartin.ca>
> 
> Acked-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> 
> Do you want me to carry that in powerpc-next ?

I can add it to kbuild-next. Changes to the top-level Makefile usually
go through kbuild, so it will avoid potential conflicts.

Michal


More information about the Linuxppc-dev mailing list