[PATCH 3/3] powerpc/spufs: remove double check for non-negative dentry

Arnd Bergmann arnd at arndb.de
Thu May 14 01:58:56 EST 2009


From: Jan Blunck <jblunck at suse.de>

This patch removes an unnecessary double check if the dentry returned by
lookup_create() is actually non-negative. Since lookup_create() itself returns
an error in this case just remove the check.

Signed-off-by: Jan Blunck <jblunck at suse.de>
Signed-off-by: Arnd Bergmann <arnd at arndb.de>
---
 arch/powerpc/platforms/cell/spufs/inode.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c
index 706eb5c..36b6700 100644
--- a/arch/powerpc/platforms/cell/spufs/inode.c
+++ b/arch/powerpc/platforms/cell/spufs/inode.c
@@ -631,10 +631,6 @@ long spufs_create(struct nameidata *nd, unsigned int flags, mode_t mode,
 	if (IS_ERR(dentry))
 		goto out_dir;
 
-	ret = -EEXIST;
-	if (dentry->d_inode)
-		goto out_dput;
-
 	mode &= ~current_umask();
 
 	if (flags & SPU_CREATE_GANG)
-- 
1.5.6.3




More information about the Linuxppc-dev mailing list