[PATCH] powerpc/85xx: Add P2020DS board support

Kumar Gala galak at kernel.crashing.org
Thu Apr 16 02:17:17 EST 2009


On Apr 15, 2009, at 10:59 AM, Timur Tabi wrote:

> On Wed, Apr 15, 2009 at 10:49 AM, Kumar Gala <galak at kernel.crashing.org 
> > wrote:
>
>> --- a/arch/powerpc/platforms/fsl_uli1575.c
>> +++ b/arch/powerpc/platforms/fsl_uli1575.c
>> @@ -57,7 +57,7 @@ static void __devinit early_uli5249(struct  
>> pci_dev *dev)
>>        unsigned char temp;
>>
>>        if (!machine_is(mpc86xx_hpcn) && !machine_is(mpc8544_ds) &&
>> -                       !machine_is(mpc8572_ds))
>> +                       !machine_is(mpc8572_ds) && ! 
>> machine_is(p2020_ds))
>>                return;
>
> Are we going to need to update this function every time we add a new
> board that has an ULI 1575 on it?  Can't we define some property in
> the device tree to handle this?

Seeing as I think this is the last board that will have the ULI 1575  
from us I don't think its worth it.

- k



More information about the Linuxppc-dev mailing list