[PATCH 1/4] allow arch specific function for allocating gigantic pages

Andi Kleen andi at firstfloor.org
Thu Mar 27 08:49:39 EST 2008


Haven't reviewed it in detail, just noticed something.

> @@ -614,6 +610,7 @@ static int __init hugetlb_init(void)
>  {
>  	if (HPAGE_SHIFT == 0)
>  		return 0;
> +	INIT_LIST_HEAD(&huge_boot_pages);
>  	return hugetlb_init_hstate(&global_hstate);

I don't think adding the INIT_LIST_HEAD here is correct. There can
be huge pages added by the __setup handlers before hugetlb_init

-Andi



More information about the Linuxppc-dev mailing list