[PATCH 1/5] powerpc: generic time suspend/resume code

Johannes Berg johannes at sipsolutions.net
Tue Mar 20 09:11:26 EST 2007


On Mon, 2007-03-19 at 22:51 +0100, Guennadi Liakhovetski wrote:

> Notice also, that my linkstation suspend patch in its present form also 
> uses the previous version of this patch from Johannes', but I'd rather 
> delay its acceptance upstream and directly go for the ultimate solution.

I just posted a whole other series of cleanup patches that depend on the
removal of the arcane pmu notifier in the timer code. I don't see the
point in holding that for much longer just because there's some big
structural change possibly coming up for the rtc code.

It's not just the generic RTC suspend code that is relevant but also the
ppc_md rtc hooks, ultimately they probably should be removed totally
once powerpc completely migrates to genrtc everywhere. In the patch you
showed me to this file you actually circumvented the ppc_md rtc hooks
because you're already using genrtc, in that case the genrtc suspend
code is obviously much more appropriate.

Since currently only 32-bit powermac even implements suspend in
mainline, the whole issue is sort of moot anyway. Once the genrtc
suspend patches is in this file can be removed with the patch that
migrates powermac to genrtc, and then new platforms wanting to implement
suspend will need to use genrtc.

johannes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20070319/ad8858d4/attachment.pgp>


More information about the Linuxppc-dev mailing list