[K42-discussion] [PATCH] Problem with install_targets

[Livio Soares]

  Hi,

  It seems some of us here at UofT have been hitting a build issue, with the CVS
tree, for quite some time.  I've only had  time now to take a quick look and fix
it.  At the "install_targets" part of the build, we see this:

cd bin/ && make -j 1 SEQ=1 install_targets
make[4]: Entering directory `/scr2/livio/k42/k42.orig/powerpc/noDeb/bin'
make[4]: *** No rule to make target `/scr2/livio/k42/k42.orig/install/powerpc/noDeb/kitchroot/kbin/kernelControl', needed by `install_targets'.  Stop.
make[4]: Leaving directory `/scr2/livio/k42/k42.orig/powerpc/noDeb/bin'
make[3]: Leaving directory `/scr2/livio/k42/k42.orig/powerpc/noDeb'
make[3]: *** [bin_install_targets] Error 2

  And, after that one, again:

cd mixed/ && make -j 1 SEQ=1 install_targets
make[6]: Entering directory `/scr2/livio/k42/k42.orig/powerpc/noDeb/kitch-linux/tests/mixed'
/usr/bin/install --mode 0775 -d /scr2/livio/k42/k42.orig/install/powerpc/noDeb/kitchroot/tests/mixed
make[6]: *** No rule to make target `/scr2/livio/k42/k42.orig/install/powerpc/noDeb/kitchroot/tests/mixed/newmemclone', needed by `install_targets'.  Stop.
make[6]: Leaving directory `/scr2/livio/k42/k42.orig/powerpc/noDeb/kitch-linux/tests/mixed'
make[5]: *** [mixed_install_targets] Error 2
  
  For some reason, make (we use version 3.81) is not recognizing this rule:

$(MKKITCHROOT)/kbin/%: %

or

$(MKKITCHROOT)/tests/mixed/%: %

  unless you explicitly  make $(TARGETS) first. I'm no  specialist in Makefiles,
but I've hacked a solution which works  for us. Patch is attached to this e-mail
for those who have possibly been similarly hit.

PS: I'm  not necessarily advocating  to apply this  to the tree,  unless someone
    comes up  with an explanation  as to  why the make  rule doesn't seem  to be
    recognized with explicitly making the target first.

   Hope this helps,

			Livio
-------------- next part --------------
Index: bin/Makefile
===================================================================
RCS file: /u/kitchawa/cvsroot/kitch-core/bin/Makefile,v
retrieving revision 1.32
diff -p -u -r1.32 Makefile
--- bin/Makefile	8 Feb 2006 06:38:27 -0000	1.32
+++ bin/Makefile	19 Oct 2006 18:36:46 -0000
@@ -86,7 +86,7 @@ $(MKKITCHROOT)/kbin/%: $(SRC_DIR_PATH)/%
 	$(INSTALL) --mode 0755 $< $@
 	$(INSTALL_DSK)
 
-install_targets:: $(INST_PROGS)
+install_targets:: $(TARGETS) $(INST_PROGS)
 
 XTRA_CLEAN = $(USRTARGETS:%=%.dbg)
 
Index: kitch-linux/tests/mixed/Makefile
===================================================================
RCS file: /u/kitchawa/cvsroot/kitch-linux/tests/mixed/Makefile,v
retrieving revision 1.33
diff -p -u -r1.33 Makefile
--- kitch-linux/tests/mixed/Makefile	18 Jul 2005 23:44:19 -0000	1.33
+++ kitch-linux/tests/mixed/Makefile	19 Oct 2006 18:36:46 -0000
@@ -48,7 +48,7 @@ $(MKKITCHROOT)/tests/mixed:
 	$(INSTALL) --mode 0775 -d $@
 
 install_targets:: $(MKKITCHROOT)/tests/mixed
-install_targets:: $(INST_PROGS)
+install_targets:: $(TARGETS) $(INST_PROGS)
 
 clean::
 	-$(RM) $(USRTARGETS:%=%.dbg)