[K42-discussion] fsfile locked_purge patch

Patrick Bozeman PEBozeman at lbl.gov
Sat Oct 7 05:05:34 EST 2006


This patch improves the locked_purge support for fsfiles.  Previously,
they were being purged without attempting to check if they were valid or
not.  Even though they were being purged from the cache, they weren't
being deleted either.  I added code to perform the delete, but left it
commented out because not all file systems can handle it yet, e.g.
devfs.   It is my understanding that any cached serverfiles will be
auto-deleted by the interaction between the cobj layer and the fslib
free list, but there was an existing comment in the code that implies
they are being leaked.  Is this true?  Can someone comment on that part?

Assuming this patch is going in the right direction to plug the leaks,
I'll submit a patch for the volatile file systems that use this code so
that we can actually perform the fsfile delete.

p.s.  Without this patch, the procfs code was leaking fsinfo objects..
and still is without the delete, but at least it isn't generating new
ones on every directory enumeration.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fsfile-purge.patch
Type: text/x-patch
Size: 4551 bytes
Desc: not available
Url : http://ozlabs.org/pipermail/k42-discussion/attachments/20061006/6ae4d2b9/attachment.bin 


More information about the K42-discussion mailing list